Skip to content

feat: added nvidia runtime if there's gpu detected #2258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
reski-rukmantiyo wants to merge 1 commit into from
Closed

feat: added nvidia runtime if there's gpu detected #2258

reski-rukmantiyo wants to merge 1 commit into from

Conversation

@reski-rukmantiyo
Copy link

@reski-rukmantiyo reski-rukmantiyo commented Oct 16, 2024

Purpose of this PR

Propose from this PR is to enable Nvidia Runtime if pod have GPU capabilites

Proposed changes:

  • Detect for any specific gpu is enabled, then runtimeClassName with change into Nvidia

Change Category

Indicate the type of change by marking the applicable boxes:

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Checklist

Before submitting your PR, please review the following:

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

@google-oss-prow
Copy link
Contributor

google-oss-prow bot commented Oct 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign vara-bonthu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ChenYi015
Copy link
Member

ChenYi015 commented Oct 18, 2024

@reski-rukmantiyo Thanks for the contribution. However, I do not think it will work because the RuntimeClassName is only added to the SparkApplication CR, not to the Spark pods.

@github-actions
Copy link

github-actions bot commented Jan 16, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions
Copy link

github-actions bot commented Feb 5, 2025

This pull request has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

@github-actions github-actions bot closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ImpSy ImpSy Awaiting requested review from ImpSy

@jacobsalway jacobsalway Awaiting requested review from jacobsalway

Assignees

No one assigned

Labels

lifecycle/stale size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reski-rukmantiyo @ChenYi015